Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add as_slice and as_mut_slice methods #182

Merged
merged 1 commit into from Nov 16, 2019
Merged

Conversation

@rklaehn
Copy link
Contributor

rklaehn commented Nov 16, 2019

To allow random access for remaining data in smallvec::IntoIter, just like
std::vec::IntoIter

Implements #181

To allow random access for remaining data in smallvec::IntoIter, just like
std::vec::IntoIter

Implements #181
@mbrubeck
Copy link
Contributor

mbrubeck commented Nov 16, 2019

@bors-servo r+

Thanks!

@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

📌 Commit bd47300 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

Testing commit bd47300 with merge c975415...

bors-servo added a commit that referenced this pull request Nov 16, 2019
Add as_slice and as_mut_slice methods

To allow random access for remaining data in smallvec::IntoIter, just like
std::vec::IntoIter

Implements #181
@bors-servo
Copy link
Contributor

bors-servo commented Nov 16, 2019

☀️ Test successful - checks-travis
Approved by: mbrubeck
Pushing c975415 to master...

@bors-servo bors-servo merged commit bd47300 into servo:master Nov 16, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this pull request Dec 19, 2019
Changes in this release:

* Added new method `SmallVec::into_boxed_slice` (servo#190).
* Added new method `IntoIter::as_slice` (servo#182).
* `IntoIter` now implements `Clone` (servo#192).
* Improved documentation and testing (servo#186, servo#189).
* Minor code cleanups (servo#176).
@mbrubeck mbrubeck mentioned this pull request Dec 19, 2019
bors-servo added a commit that referenced this pull request Dec 20, 2019
Version 1.1.0

Changes in this release:

* Added new method `SmallVec::into_boxed_slice` (#190).
* Added new methods `IntoIter::as_slice` and `as_mut_slice` (#182).
* `IntoIter` now implements `Clone` (#192).
* Improved documentation and testing (#186, #189).
* Minor code cleanups (#176).

Also added a simple example to the README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.