Skip to content

/ rust-smallvec

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miri now supports catching panics #186

Merged
merged 3 commits into from Dec 9, 2019
Merged

Miri now supports catching panics #186

merged 3 commits into from Dec 9, 2019

Conversation

@RalfJung
Copy link
Contributor

RalfJung commented Dec 6, 2019

Also fix a mistake in the .gitignore (at least on my system, this didn't actually ignore the lockfile)
@RalfJung
Miri now supports catching panics
Loading status checks…
bb8ae2b
@thomcc
Copy link
Contributor

thomcc commented Dec 6, 2019

This is missing https://github.com/servo/rust-smallvec/blob/master/lib.rs#L1987 too, but otherwise is awesome to see.
@RalfJung
enable more tests in Miri and fix sue of 'std' feature
Loading status checks…
e36401b
@RalfJung
Copy link
Contributor Author

RalfJung commented Dec 7, 2019

@thomcc that test is quite odd as it is never actually enabled even without Miri! The std feature does not seem to exist any more, but still has some references left to it in the code. I fixed that.

However, when Miri runs test_insert_many_panic, it reports a memory leak: two heap allocations of size 1 get leaked. I assume that is the two Box::new(false) in that test. Is it expected that those get leaked?
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 8, 2019

Is it expected that those get leaked?

Yes, we intentionally leak on panic in insert_many. See #96 and 26b2490 for details.
@RalfJung
ignore memory leaks
Loading status checks…
ddfa856
@RalfJung
Copy link
Contributor Author

RalfJung commented Dec 9, 2019

Okay, Miri can now ignore leaks and I added that flag here. Should be good to go.
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 9, 2019

@bors-servo r+

Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2019

📌 Commit ddfa856 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2019

⌛ Testing commit ddfa856 with merge 6f0fe55...
bors-servo added a commit that referenced this pull request Dec 9, 2019
@bors-servo
Auto merge of #186 - RalfJung:miri, r=mbrubeck
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6f0fe55 
Miri now supports catching panics

Also fix a mistake in the .gitignore (at least on my system, this didn't actually ignore the lockfile)
@bors-servo
Copy link
Contributor

bors-servo commented Dec 9, 2019

☀️ Test successful - checks-travis
Approved by: mbrubeck
Pushing 6f0fe55 to master...
@bors-servo bors-servo merged commit ddfa856 into servo:master Dec 9, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@RalfJung RalfJung deleted the RalfJung:miri branch Dec 9, 2019
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this pull request Dec 19, 2019
@mbrubeck
Version 1.1.0
436dedb 
Changes in this release:

* Added new method `SmallVec::into_boxed_slice` (servo#190).
* Added new method `IntoIter::as_slice` (servo#182).
* `IntoIter` now implements `Clone` (servo#192).
* Improved documentation and testing (servo#186, servo#189).
* Minor code cleanups (servo#176).
@mbrubeck mbrubeck mentioned this pull request Dec 19, 2019
Merged
bors-servo added a commit that referenced this pull request Dec 20, 2019
@bors-servo
Auto merge of #193 - mbrubeck:bump, r=emilio
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
34d7b8d 
Version 1.1.0

Changes in this release:

* Added new method `SmallVec::into_boxed_slice` (#190).
* Added new methods `IntoIter::as_slice` and `as_mut_slice` (#182).
* `IntoIter` now implements `Clone` (#192).
* Improved documentation and testing (#186, #189).
* Minor code cleanups (#176).

Also added a simple example to the README.
@mbrubeck mbrubeck mentioned this pull request Apr 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@RalfJung @thomcc @mbrubeck @bors-servo
You can’t perform that action at this time.