Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Clone for IntoIter where A: Clone #191
Closed
+64
−0
Conversation
|
Ah, I forgot that I think we should use the more-general, less-performant version for now, and when specialization is available we can use it to optimize the If you use |
|
Sorry, I'm trying out Visual Studio's git plugin, and it seems I'm doing things wrong... |
|
#192 should be correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
L0uisc commentedDec 12, 2019
Implements
CloneforIntoIter<A>whereA: Array + CloneandA::Item: Copy(necessary to be able to usefrom_slice()) as per #178.I also left a commented implementation which requires
A::Itemto be the more relaxedClone, which also works. However, it will be less efficient than the other impl when the types areCopybecause it can't usefrom_slice(). I believe the feature I'm looking for is specialization?