Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Clone for IntoIter<A> where A: Clone #192

Merged
merged 2 commits into from Dec 13, 2019

Conversation

@L0uisc
Copy link
Contributor

L0uisc commented Dec 12, 2019

Implemented code to fix #178. The commented impl can be uncommented once specialization is possible. Both impls were tested and passed the three added tests.

Copy link
Contributor

mbrubeck left a comment

Thanks! One minor change and then this is ready for approval:

lib.rs Outdated Show resolved Hide resolved
@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 13, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

📌 Commit 1fa1545 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

Testing commit 1fa1545 with merge 941d6aa...

bors-servo added a commit that referenced this pull request Dec 13, 2019
Implement Clone for IntoIter<A> where A: Clone

Implemented code to fix #178. The commented impl can be uncommented once specialization is possible. Both impls were tested and passed the three added tests.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2019

☀️ Test successful - checks-travis
Approved by: mbrubeck
Pushing 941d6aa to master...

@bors-servo bors-servo merged commit 1fa1545 into servo:master Dec 13, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this pull request Dec 19, 2019
Changes in this release:

* Added new method `SmallVec::into_boxed_slice` (servo#190).
* Added new method `IntoIter::as_slice` (servo#182).
* `IntoIter` now implements `Clone` (servo#192).
* Improved documentation and testing (servo#186, servo#189).
* Minor code cleanups (servo#176).
@mbrubeck mbrubeck mentioned this pull request Dec 19, 2019
bors-servo added a commit that referenced this pull request Dec 20, 2019
Version 1.1.0

Changes in this release:

* Added new method `SmallVec::into_boxed_slice` (#190).
* Added new methods `IntoIter::as_slice` and `as_mut_slice` (#182).
* `IntoIter` now implements `Clone` (#192).
* Improved documentation and testing (#186, #189).
* Minor code cleanups (#176).

Also added a simple example to the README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.