Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Send and Sync on SmallVec #20

Merged
merged 1 commit into from Mar 30, 2016
Merged

Implement Send and Sync on SmallVec #20

merged 1 commit into from Mar 30, 2016

Conversation

@tomaka
Copy link
Contributor

tomaka commented Mar 30, 2016

Because of the core team's questionable decision of not implementing Send and Sync on raw pointers, we need to implement them manually.


This change is Reviewable

@metajack
Copy link
Contributor

metajack commented Mar 30, 2016

@pcwalton
Copy link

pcwalton commented Mar 30, 2016

@bors-servo: r+

For what it's worth, this was not a core team decision

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

📌 Commit 5ece9b2 has been approved by pcwalton

@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

Testing commit 5ece9b2 with merge c404b8b...

bors-servo added a commit that referenced this pull request Mar 30, 2016
Implement Send and Sync on SmallVec

Because of the core team's questionable decision of not implementing Send and Sync on raw pointers, we need to implement them manually.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/20)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 5ece9b2 into servo:master Mar 30, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@tomaka tomaka deleted the tomaka:patch-1 branch Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.