Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement PartialEq, Eq, PartialOrd, Ord on SmallVec. #22
Conversation
|
Looks good, thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 24, 2016
Implement PartialEq, Eq, PartialOrd, Ord on SmallVec. Currently one can compare slices, but having the traits on the `SmallVec` itself is slightly more convenient. Perhaps there's a reason these traits aren't yet implemented, but if not, here's a PR! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/22) <!-- Reviewable:end -->
|
|
Merged
bors-servo
added a commit
that referenced
this pull request
Jun 14, 2016
Release version 0.1.8 Fixes #24. Changelog: * #22 Implement PartialEq, Eq, PartialOrd, and Ord on SmallVec <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/25) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cfallin commentedMay 24, 2016
•
edited by larsbergstrom
Currently one can compare slices, but having the traits on the
SmallVecitself is slightly more convenient. Perhaps there's a reason these traits aren't yet implemented, but if not, here's a PR!This change is