Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use min_const_generics

Merged
merged 1 commit into from Aug 11, 2020
Merged

Use min_const_generics #232

merged 1 commit into from Aug 11, 2020

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Aug 9, 2020

No description provided.

@jdm
Copy link
Member

jdm commented Aug 9, 2020

error[E0658]: const generics are unstable

    --> src/lib.rs:1910:22

     |

1910 | unsafe impl<T, const N: usize> Array for [T; N] {

     |                      ^

     |

     = note: see issue #44580 <https://github.com/rust-lang/rust/issues/44580> for more information

     = help: add `#![feature(const_generics)]` to the crate attributes to enable

@jdm
Copy link
Member

jdm commented Aug 9, 2020

That failure occurs as part of this command.

@mbrubeck
Copy link
Contributor

mbrubeck commented Aug 10, 2020

We'll need to wait for a newer nightly that includes miri.

@mbrubeck
Copy link
Contributor

mbrubeck commented Aug 11, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2020

📌 Commit 0e23d2a has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2020

Testing commit 0e23d2a with merge 87500c3...

@bors-servo
Copy link
Contributor

bors-servo commented Aug 11, 2020

☀️ Test successful - checks-travis
Approved by: mbrubeck
Pushing 87500c3 to master...

@bors-servo bors-servo merged commit 87500c3 into servo:master Aug 11, 2020
1 of 2 checks passed
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this issue Aug 11, 2020
* `insert_many` no longer leaks elements if the provided iterator panics (servo#213).
* The unstable `const_generics` and `specialization` features are
  updated to work with the most recent nightly Rust toolchain (servo#232).
* Internal code cleanup (servo#229, servo#231).
@mbrubeck mbrubeck mentioned this pull request Aug 11, 2020
bors-servo added a commit that referenced this issue Aug 11, 2020
Version 1.4.2

Changelog:

* `insert_many` no longer leaks elements if the provided iterator panics (#213).
* The unstable `const_generics` and `specialization` features are updated to work with the most recent nightly Rust toolchain (#232).
* Internal code cleanup (#229, #231).

This PR also changes the `author` field in `Cargo.toml` to "The Servo Project Developers".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants