Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min_const_generics feature

Merged
merged 1 commit into from Dec 28, 2020
Merged

Conversation

c410-f3r
Copy link
Contributor

@c410-f3r c410-f3r commented Dec 2, 2020

Depends on rust-lang/rust#79135.

If #240 is already under development and will be available before the 1.50 release, then feel free to close this PR. Otherwise, the feature removal will benefit upstream projects in the meanwhile.

@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 2, 2020

Thanks!

We will need to wait until rust-lang/rust#79135 is merged and released to the nightly channel before we can merge this PR.

src/lib.rs Outdated
@@ -1934,34 +1933,13 @@ impl<'a> Drop for SetLenOnDrop<'a> {
}
}

#[cfg(feature = "const_generics")]
Copy link
Contributor

@mbrubeck mbrubeck Dec 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep use of const generics behind an optional feature in smallvec 1.x, so it can continue compiling on Rust versions older than 1.51. Let's wait until 2.0 to remove this feature completely.

Copy link
Contributor Author

@c410-f3r c410-f3r Dec 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooopsss... My bad :p

@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 28, 2020

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Dec 28, 2020

📌 Commit 2964a84 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Dec 28, 2020

Testing commit 2964a84 with merge e4c73e4...

@bors-servo
Copy link
Contributor

bors-servo commented Dec 28, 2020

☀️ Test successful - checks-travis
Approved by: mbrubeck
Pushing e4c73e4 to master...

@bors-servo bors-servo merged commit e4c73e4 into servo:master Dec 28, 2020
1 of 2 checks passed
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this issue Dec 31, 2020
Release notes:

* The `union` feature is now compatible with stable Rust 1.50 (servo#248).
* The `const_generics` feature is now compatible with Rust 1.51-beta
  (servo#242).
* Fixed warnings when compiling with Rust 1.51-beta (servo#246).
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this issue Dec 31, 2020
Release notes:

* The `union` feature is now compatible with stable Rust 1.49 (servo#248).
* Fixed warnings when compiling with Rust 1.51 nightly (servo#242, servo#246).
@mbrubeck mbrubeck mentioned this pull request Dec 31, 2020
bors-servo added a commit that referenced this issue Dec 31, 2020
Version 1.6.0

Release notes:

* The `union` feature is now compatible with stable Rust 1.49 (#248, #247).
* Fixed warnings when compiling with Rust 1.51 nightly (#242, #246).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants