Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap with ManuallyDrop so that the union feature works on 1.50

Merged
merged 1 commit into from Dec 31, 2020

Conversation

saethlin
Copy link
Contributor

@saethlin saethlin commented Dec 31, 2020

Per #247 (comment)

The unrelated diff was produced by rustfmt, which my editor runs automatically. I'm a bit surprised, usually when this produces a diff it's a big one. Do you want me to revert those lines?

@mbrubeck
Copy link
Contributor

mbrubeck commented Dec 31, 2020

@bors-servo r+

Thanks! The rustfmt changes are fine, too.

@bors-servo
Copy link
Contributor

bors-servo commented Dec 31, 2020

📌 Commit 2785548 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Dec 31, 2020

Testing commit 2785548 with merge 73a8953...

@bors-servo
Copy link
Contributor

bors-servo commented Dec 31, 2020

☀️ Test successful - checks-travis
Approved by: mbrubeck
Pushing 73a8953 to master...

@bors-servo bors-servo merged commit 73a8953 into servo:master Dec 31, 2020
2 checks passed
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this issue Dec 31, 2020
Release notes:

* The `union` feature is now compatible with stable Rust 1.50 (servo#248).
* The `const_generics` feature is now compatible with Rust 1.51-beta
  (servo#242).
* Fixed warnings when compiling with Rust 1.51-beta (servo#246).
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this issue Dec 31, 2020
Release notes:

* The `union` feature is now compatible with stable Rust 1.49 (servo#248).
* Fixed warnings when compiling with Rust 1.51 nightly (servo#242, servo#246).
@mbrubeck mbrubeck mentioned this pull request Dec 31, 2020
bors-servo added a commit that referenced this issue Dec 31, 2020
Version 1.6.0

Release notes:

* The `union` feature is now compatible with stable Rust 1.49 (#248, #247).
* Fixed warnings when compiling with Rust 1.51 nightly (#242, #246).
dtolnay added a commit to dtolnay/syn that referenced this issue Jan 1, 2021
The previously pinned rustfmt commit + toolchain have no longer been
compiling as of servo/rust-smallvec#248.

    error[E0658]: unions with non-`Copy` fields are unstable
       --> /home/david/.cargo/registry/src/github.com-1ecc6299db9ec823/smallvec-1.6.0/src/lib.rs:353:1
        |
    353 | / union SmallVecData<A: Array> {
    354 | |     inline: core::mem::ManuallyDrop<MaybeUninit<A>>,
    355 | |     heap: (*mut A::Item, usize),
    356 | | }
        | |_^
        |
        = note: see issue #55149 <rust-lang/rust#55149> for more information
        = help: add `#![feature(untagged_unions)]` to the crate attributes to enable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants