Add benchmarks for push, insert, extend, and pushpop #31

nipunn1313 · 2016-08-27T21:06:24Z

Want to add these benchmarks so that we can more effectively detect regressions/improvements from PR's like #28 and #29.

This change is


        Add benchmarks for push, insert, extend, and pushpop

emilio · 2016-08-28T00:40:37Z

lib.rs

@@ -5,6 +5,8 @@
 //! Small vectors in various sizes. These store a certain number of elements inline and fall back
 //! to the heap for larger allocations.

+#![feature(test)]


This won't compile in stable, will it?

Correct. Let me work on factoring it into a conditionally compiled feature which is disabled by default.

emilio · 2016-08-28T00:43:02Z

lib.rs

+    fn bench_push(b: &mut Bencher) {
+        b.iter(|| {
+            let mut vec: SmallVec<[u64; 16]> = SmallVec::new();
+            for x in 0..100 {


Also, I think the compiler will be pretty much able to optimize these loops out. IIRC there was some builtin support for black box testing for this kind of things. I think we should be able to enforce that using it, or at least confirm it's not being optimized out.

I believe if the closure returns a value then the optimizer will not remove it.

I was empirically able to determine that the optimizer was not removing the code either way (for now), but I will include the vec return value to ensure it.


        Add .travis.yml. Bench closures return values. Feature gate.

nipunn1313 · 2016-08-28T03:10:43Z

Looks like this on my machine (Mac book pro laptop)

Nipunns-MacBook-Pro:rust-smallvec nipunn$ cargo bench --verbose --features=benchmarks bench
       Fresh smallvec v0.2.0 (file:///Users/nipunn/src/rust-smallvec)
    Finished release [optimized] target(s) in 0.0 secs
     Running `/Users/nipunn/src/rust-smallvec/target/release/deps/smallvec-a59689f47ae774cb bench --bench`

running 4 tests
test bench::bench_extend  ... bench:         169 ns/iter (+/- 19)
test bench::bench_insert  ... bench:       1,201 ns/iter (+/- 267)
test bench::bench_push    ... bench:         295 ns/iter (+/- 39)
test bench::bench_pushpop ... bench:         357 ns/iter (+/- 117)

test result: ok. 0 passed; 0 failed; 0 ignored; 4 measured

Travis CI looked like this. I don't think we can really rely on its numbers though.

running 4 tests
test bench::bench_extend  ... bench:         182 ns/iter (+/- 3)
test bench::bench_insert  ... bench:       1,916 ns/iter (+/- 21)
test bench::bench_push    ... bench:         307 ns/iter (+/- 6)
test bench::bench_pushpop ... bench:         383 ns/iter (+/- 6)```

nipunn1313 · 2016-09-11T02:14:13Z

Any update on this?

jdm · 2016-09-11T13:17:48Z

@bors-servo: r+
Thanks for doing this work!

bors-servo · 2016-09-11T13:17:49Z

📌 Commit 951f1d0 has been approved by jdm

bors-servo · 2016-09-11T13:17:51Z

⚡ Test exempted - status


        Auto merge of #31 - nipunn1313:bench, r=jdm

Add benchmarks for push, insert, extend, and pushpop Want to add these benchmarks so that we can more effectively detect regressions/improvements from PR's like #28 and #29.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/31)

Add benchmarks for push, insert, extend, and pushpop

Loading status checks…

abf82ff

emilio reviewed Aug 28, 2016
View changes

nipunn1313 force-pushed the nipunn1313:bench branch from 232f805 to ff9e2f0 Aug 28, 2016

Add .travis.yml. Bench closures return values. Feature gate.

Loading status checks…

951f1d0

nipunn1313 force-pushed the nipunn1313:bench branch from ff9e2f0 to 951f1d0 Aug 28, 2016

bors-servo merged commit 951f1d0 into servo:master Sep 11, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

nipunn1313 deleted the nipunn1313:bench branch Sep 12, 2016

servo / rust-smallvec

Add benchmarks for push, insert, extend, and pushpop #31

Add benchmarks for push, insert, extend, and pushpop #31

nipunn1313 commented Aug 27, 2016 •

edited by larsbergstrom

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nipunn1313 commented Aug 28, 2016 •

edited

nipunn1313 commented Sep 11, 2016

jdm commented Sep 11, 2016

bors-servo commented Sep 11, 2016

bors-servo commented Sep 11, 2016

servo / rust-smallvec

Join GitHub today

Add benchmarks for push, insert, extend, and pushpop #31

Add benchmarks for push, insert, extend, and pushpop #31

Conversation

nipunn1313 commented Aug 27, 2016 • edited by larsbergstrom

This comment has been minimized.

emilio Aug 28, 2016

This comment has been minimized.

nipunn1313 Aug 28, 2016 • edited

This comment has been minimized.

emilio Aug 28, 2016

This comment has been minimized.

nipunn1313 Aug 28, 2016

nipunn1313 commented Aug 28, 2016 • edited

nipunn1313 commented Sep 11, 2016

jdm commented Sep 11, 2016

bors-servo commented Sep 11, 2016

bors-servo commented Sep 11, 2016

nipunn1313 commented Aug 27, 2016 •

edited by larsbergstrom

nipunn1313 Aug 28, 2016 •

edited

nipunn1313 commented Aug 28, 2016 •

edited