Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove benchmarks to benches module with noinline wrappers #32
Conversation
|
Used a #noinline wrapper from benchmarks to get more consistent results. Looks like the results are a bit worse, but more consistent/realistic since the compiler's inlining during the benchmark itself won't affect the performance.
|
|
I verified by disassembling the generated executables that beforehand, insert() was being inlined, but after this change it is not. This accounts for the dip in the bench_insert |
|
Ping on these improvements to the benchmarks. |
|
@bors-servo: r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 14, 2016
Move benchmarks to benches module with noinline wrappers This ensures that the benchmarks are in a separate crate and linked against the smallvec dynamic library rather than being compiled together. It also nicely removes the need for the "benchmarks" feature. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/32) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nipunn1313 commentedSep 12, 2016
•
edited by larsbergstrom
This ensures that the benchmarks are in a separate crate and linked
against the smallvec dynamic library rather than being compiled
together.
It also nicely removes the need for the "benchmarks" feature.
This change is