Skip to content

/ rust-smallvec

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that VecLike derefs to a slice #38

Merged
merged 2 commits into from Oct 5, 2016
Merged

Specify that VecLike derefs to a slice #38

merged 2 commits into from Oct 5, 2016

Conversation

@Marwes
Copy link
Contributor

Marwes commented Oct 5, 2016 •
edited by larsbergstrom

I believe this is just an oversight. Since <[T]>::len is now available through the Deref bound I also removed VecLike::len.

This change is Reviewable
Marwes added 2 commits Oct 5, 2016
@Marwes
Specify that VecLike derefs to a slice
f6ce36c 
This gives direct access to functions such as `is_empty` when only a `VecLike` bound is specified.

BREAKING CHANGE

This removes the `VecLike::len` method which is superseeded by the `len`
method on `[T]`
@Marwes
Version 0.3.0
Loading status checks…
7e9787f
@jdm
Copy link
Member

jdm commented Oct 5, 2016

@bors-servo: r+
Thanks!
@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2016

📌 Commit 7e9787f has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 5, 2016

⚡ Test exempted - status
@bors-servo bors-servo merged commit 7e9787f into servo:master Oct 5, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test exempted
Details
bors-servo added a commit that referenced this pull request Oct 5, 2016
@bors-servo
Auto merge of #38 - Marwes:deref_slice, r=jdm
Loading status checks…
7b97ffc 
Specify that VecLike derefs to a slice

I believe this is just an oversight. Since `<[T]>::len` is now available through the `Deref` bound I also removed `VecLike::len`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/38)
<!-- Reviewable:end -->
@Marwes Marwes deleted the Marwes:deref_slice branch Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Marwes @jdm @bors-servo
You can’t perform that action at this time.