Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDocs, code cleanup, and misc. fixes for smallvec #40
+163
−20
Conversation
mbrubeck
force-pushed the
mbrubeck:docs
branch
2 times, most recently
from
c0f6ad0
to
3ac0159
lib.rs
Outdated
| @@ -130,13 +150,45 @@ impl<A: Array> Drop for SmallVecData<A> { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| /// A Vec-like that can store a small number of elements inline. | |||
This comment has been minimized.
This comment has been minimized.
lib.rs
Outdated
| @@ -245,6 +310,9 @@ impl<A: Array> SmallVec<A> { | |||
| } | |||
| } | |||
|
|
|||
| /// Reserve capacity for at least `additional` more elements to be inserted. | |||
| /// | |||
| /// May reserve more space to avoid frequent reallocations. | |||
This comment has been minimized.
This comment has been minimized.
Ms2ger
Dec 5, 2016
Contributor
Maybe make a note about overflow behaviour. In particular, it is not safe to assume that you can actually fit additional new elements in it!
lib.rs
Outdated
| if self.spilled() && self.capacity() > len { | ||
| if len <= self.inline_size() { | ||
| unsafe { | ||
| let (ptr, capacity) = match &self.data { |
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=Ms2ger
|
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 6, 2016
Docs, code cleanup, and misc. fixes for smallvec <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/40) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedDec 5, 2016
•
edited by larsbergstrom
This change is