Skip to content

/ rust-smallvec

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl std::io::Write for SmallVec #52

Merged
merged 1 commit into from Jun 22, 2017
Merged

impl std::io::Write for SmallVec #52

merged 1 commit into from Jun 22, 2017

Conversation

@chpio
Copy link
Contributor

chpio commented Jun 1, 2017 •
edited by larsbergstrom

This change is Reviewable
@chpio
Copy link
Contributor Author

chpio commented Jun 1, 2017 •
edited

this collides with the no_std pr because all other std modules are part of core but io is not.
@mbrubeck
mbrubeck approved these changes Jun 19, 2017
View changes
Copy link
Contributor

mbrubeck left a comment •
edited

This looks good. Thanks! Sorry for the delay. I plan to merge this, but I'll give #49 a chance to land first since it's been waiting even longer.
@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 20, 2017

#49 has landed now, so this should be rebased on top of it, and #[cfg(feature = "std")] should be added to all the new code.
@chpio
impl std::io::Write for SmallVec
Loading status checks…
e96793e
@chpio
chpio reviewed Jun 22, 2017
View changes
lib.rs
@@ -1436,4 +1458,21 @@ pub mod tests {
assert_eq!(&*small_vec, &[1, 2, 3, 4, 5]);
drop(small_vec);
}

#[cfg(feature = "std")]

This comment has been minimized.

Sign in to view
@chpio

chpio Jun 22, 2017 •
edited

Author Contributor

Is that the correct way of doing this? I guess it is if you want the tests to pass on core.
@mbrubeck
Copy link
Contributor

mbrubeck commented Jun 22, 2017

@bors-servo r+

Yes, thanks! When merged with #53, this builds and passes tests both with and without the std feature.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2017

📌 Commit e96793e has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2017

⌛ Testing commit e96793e with merge 0627339...
bors-servo added a commit that referenced this pull request Jun 22, 2017
@bors-servo
Auto merge of #52 - chpio:master, r=mbrubeck
Loading status checks…
0627339 
impl std::io::Write for SmallVec

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/52)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2017

☀️ Test successful - status-travis
Approved by: mbrubeck
Pushing 0627339 to master...
@bors-servo bors-servo merged commit e96793e into servo:master Jun 22, 2017
1 of 2 checks passed
1 of 2 checks passed
homu Testing commit e96793e571a84a0e98656c2cf1361c324f29bd3b with merge 062733901d775fcb481381151ed29b072945e199...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this pull request Jun 23, 2017
@mbrubeck
Release version 0.4.1
0f478cc 
New features:

* `no_std` support (servo#49).
* `SmallVec<[u8; N]>` implements the `Write` trait (servo#52).
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this pull request Jun 28, 2017
@mbrubeck
Release version 0.4.1
bf9ac18 
New features:

* `no_std` support (servo#49).
* `SmallVec<[u8; N]>` implements the `Write` trait (servo#52).
* Add an `ExtendFromSlice` trait for both `Vec` and `SmallVec` (servo#54).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrubeck mbrubeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@chpio @mbrubeck @bors-servo
You can’t perform that action at this time.