Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd serde support #57
Merged
Conversation
Cargo.toml
Outdated
| @@ -11,6 +11,7 @@ documentation = "http://doc.servo.org/smallvec/" | |||
|
|
|||
| [features] | |||
| heapsizeof = ["heapsize", "std"] | |||
| serde_support = ["serde"] | |||
This comment has been minimized.
This comment has been minimized.
mbrubeck
Aug 8, 2017
Contributor
The Rust API guidelines recommend using just the crate name serde, rather than adding a separate feature name.
|
@mbrubeck done. |
torkleyy left a comment
|
Looks great, but I think the changes to |
| cargo test --verbose && | ||
| cargo test --features=heapsizeof --verbose && | ||
| cargo test --all-features --verbose && |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
r? @mbrubeck The absence of this feature is blocking other work I'm doing so I'd really like to get this merged and pushed to cargo. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 10, 2017
Add serde support Things done in this PR: - Add optional serde dependency - Add Serialize and Deserialize implementations to SmallVec - Add test_serde to verify functionality. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/57) <!-- Reviewable:end -->
|
|
mbrubeck
added a commit
to mbrubeck/rust-smallvec
that referenced
this pull request
Aug 10, 2017
Merged
bors-servo
added a commit
that referenced
this pull request
Aug 11, 2017
Release version 0.4.2. * Add `SmallVec::from_buf` constructor (#56). * Add optional `serde` (de-)serialization support (#57). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/58) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Xaeroxe commentedAug 8, 2017
•
edited
Things done in this PR:
This change is