Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `heapsize` dependency. #68

Merged
merged 1 commit into from Oct 24, 2017
Merged

Conversation

@nnethercote
Copy link
Contributor

nnethercote commented Oct 24, 2017

The heapsize crate is being deprecated in favour of the malloc_size_of
crate within Servo.


This change is Reviewable

@nnethercote
Copy link
Contributor Author

nnethercote commented Oct 24, 2017

I haven't updated the version number. I'm not sure if I should.

@jdm
Copy link
Member

jdm commented Oct 24, 2017

Yes, increasing it to 0.5.0 will be necessary.

The heapsize crate is being deprecated in favour of the malloc_size_of
crate within Servo.
@nnethercote nnethercote force-pushed the nnethercote:rm-heapsize branch from 833b3ed to 79766e5 Oct 24, 2017
@nnethercote
Copy link
Contributor Author

nnethercote commented Oct 24, 2017

I updated to 0.5.0.

@mbrubeck
Copy link
Contributor

mbrubeck commented Oct 24, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2017

📌 Commit 79766e5 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2017

Testing commit 79766e5 with merge 28b9110...

bors-servo added a commit that referenced this pull request Oct 24, 2017
Remove `heapsize` dependency.

The heapsize crate is being deprecated in favour of the malloc_size_of
crate within Servo.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/68)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Oct 24, 2017

☀️ Test successful - status-travis
Approved by: mbrubeck
Pushing 28b9110 to master...

@bors-servo bors-servo merged commit 79766e5 into servo:master Oct 24, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.