Skip to content

/ rust-smallvec

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SmallVec::drop sound and other stuff #7

Merged
merged 4 commits into from Jun 10, 2015
Merged

Make SmallVec::drop sound and other stuff #7

merged 4 commits into from Jun 10, 2015

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jun 10, 2015

  • Use an enum so that we’re not dropping uninitialized T inside [T; $size]
  • Move fields into that enum to make the struct smaller
  • Refactor to be generic over array types rather than generate multiple SmallVecN types with macros.

r? @Manishearth
SimonSapin added 4 commits Jun 10, 2015
@SimonSapin
Make SmallVec::drop sound. Fix #4, fix #5.
4b377a2
@SimonSapin
Make SmallVec smaller.
1e29eed 
The pointer and capacity fields are only used when spilled, move them into the enum.
@SimonSapin
Have types like SmallVec<[T; 4]> rather than SmallVec4<T>.
Loading status checks…
32ef759
@SimonSapin
Remove begin/end methods.
Loading status checks…
a298e42
@Manishearth
Copy link
Member

Manishearth commented Jun 10, 2015

r+
Manishearth added a commit that referenced this pull request Jun 10, 2015
@Manishearth
Merge pull request #7 from servo/stuff
Loading status checks…
e360a71 
Make SmallVec::drop sound and other stuff
@Manishearth Manishearth merged commit e360a71 into master Jun 10, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@SimonSapin SimonSapin deleted the stuff branch Jun 10, 2015
@bluss
Copy link
Contributor

bluss commented Jun 10, 2015

With acknowledgment of: using ideas like Nodrop & Array trait from @bluss' arrayvec crate.
@SimonSapin
Copy link
Member Author

SimonSapin commented Jun 10, 2015

Yes, sorry I forgot to mention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@SimonSapin @Manishearth @bluss
You can’t perform that action at this time.