Integer Overflow on odd `file` URL #124

Closed
alexcrichton opened this Issue Aug 10, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@alexcrichton
Contributor

alexcrichton commented Aug 10, 2015

This code:

"file:...".parse::<Url>();

will yield this error:

test tests::bad_file_url ... FAILED

failures:

---- tests::bad_file_url stdout ----
        thread 'tests::bad_file_url' panicked at 'arithmetic operation overflowed', src/parser.rs:287



failures:
    tests::bad_file_url

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured

@alexcrichton alexcrichton referenced this issue in rust-lang/cargo Aug 10, 2015

Closed

Runtime assert with invalid dependency #1884

bors-servo pushed a commit that referenced this issue Aug 10, 2015

bors-servo
Auto merge of #125 - servo:124, r=metajack
Fix #124 integer underflow in slicing base URL path components.

#124

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/125)
<!-- Reviewable:end -->

bors-servo pushed a commit that referenced this issue Aug 11, 2015

bors-servo
Auto merge of #125 - servo:124, r=metajack
Fix #124 integer underflow in slicing base URL path components.

#124

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/125)
<!-- Reviewable:end -->
@SimonSapin

This comment has been minimized.

Show comment
Hide comment
@SimonSapin

SimonSapin Aug 13, 2015

Member

v0.2.37 is on crates.io.

Member

SimonSapin commented Aug 13, 2015

v0.2.37 is on crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment