New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for crate evaluation #319

Closed
brson opened this Issue May 4, 2017 · 6 comments

Comments

Projects
None yet
5 participants

@brson brson added the help wanted label May 4, 2017

@theduke

This comment has been minimized.

Copy link
Contributor

theduke commented May 13, 2017

Probably relevant: #338

@SimonSapin SimonSapin removed the help wanted label Jun 14, 2017

@rap2hpoutre

This comment has been minimized.

Copy link
Contributor

rap2hpoutre commented Jun 28, 2017

Except for #304 #308 #314 and #317 everything seems to be fixed now. Maybe we should update the tracking message above @brson?

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Jul 6, 2017

I updated the op. Thanks @rap2hpoutre

bors-servo added a commit that referenced this issue Jul 17, 2017

Auto merge of #382 - rap2hpoutre:master, r=SimonSapin
add more documentation for errors

More documentations for errors.  See #319 and #379

_Side question: I don't know how to document errors when a function returns `Result<(), ()>` so I did not document that part. I would be happy to see one example._

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/382)
<!-- Reviewable:end -->
@KodrAus

This comment has been minimized.

Copy link

KodrAus commented Jul 31, 2017

Looks like the only outstanding issue now is Move serde 1.0 support in-crate

@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented Jul 31, 2017

Which is semi-blocked on serde-rs/serde#953.

@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented Oct 17, 2018

Serde 1.0 support is tracked separately, so it seems this issue as served it purpose.

@SimonSapin SimonSapin closed this Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment