Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCorrect precent/percent misspelling #10
Merged
+12
−12
Conversation
SimonSapin
added a commit
that referenced
this pull request
Aug 12, 2014
Correct precent/percent misspelling [breaking-change]
|
Good catch, thanks! I’ve taken the rustc convention of having |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
zarvox commentedAug 12, 2014
There appears to be a misspelling in most of the lossy_precent_decode_* functions. This commit fixes the function as well as the docs.
Renaming these might break code that depends on this misspelling, though. Is there a good way to make a smooth migration, or do we just fix things and assume that dependent code will sort itself out soon enough?