Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percent encode curly braces #104

Closed
wants to merge 1 commit into from
Closed

Percent encode curly braces #104

wants to merge 1 commit into from

Conversation

@valenting
Copy link
Collaborator

valenting commented May 8, 2015

According to https://bugzilla.mozilla.org/show_bug.cgi?id=1152455#c6 most UAs encode curly braces in the path of the URL.
I think rust-url should do the same.

@SimonSapin
Copy link
Member

SimonSapin commented May 8, 2015

The spec says it must not: https://url.spec.whatwg.org/#percent-encoded-bytes . If the spec is wrong, an issue should be filed on it and discussed before we unilaterally start deviating. (See "Participate" near the top of the spec, and feel free to @-mention me in spec issues.)

@valenting
Copy link
Collaborator Author

valenting commented May 8, 2015

@valenting
Copy link
Collaborator Author

valenting commented Jun 15, 2015

The spec has been changed: whatwg/url#16

@SimonSapin
Copy link
Member

SimonSapin commented Jun 15, 2015

The spec added { and } to the "default encode set". I’d prefer doing that as well rather than some other change, even if the black-box behaviour happens to be identical (which I’m not convinced it is).

@valenting
Copy link
Collaborator Author

valenting commented Jun 15, 2015

Right, that sounds fair. I'm closing this PR. Let me know if you want me to submit another, or if it's faster to change it yourself.
Thanks!

@valenting valenting closed this Jun 15, 2015
@SimonSapin
Copy link
Member

SimonSapin commented Jun 15, 2015

Done in 79a9ef1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.