implement FromStr for Url

[blaenk]

This enables the use of the parse() method on &str

Fixes #18.

[seanmonstar]

Just warning, this has been closed as wontfix a few times now.

On Sat, May 9, 2015, 4:02 PM Jorge Israel Peña notifications@github.com
wrote:

This enables the use of the parse() method on &str

You can view, comment on, or merge this pull request online at:

#107
Commit Summary

• implement FromStr for Url

File Changes

• M src/lib.rs
  https://github.com/servo/rust-url/pull/107/files#diff-0 (8)
• M src/tests.rs
  https://github.com/servo/rust-url/pull/107/files#diff-1 (5)

Patch Links:

• https://github.com/servo/rust-url/pull/107.patch
• https://github.com/servo/rust-url/pull/107.diff

—
Reply to this email directly or view it on GitHub
#107.

[blaenk]

Thanks for the heads up, I guess I should've searched, but I didn't think it would be particularly controversial. I've contributed the same change to the rust-lang/regex and rust-lang/glob packages and they were merged.

[blaenk]

From @SimonSapin in #18:

I’ve resisted doing this so far because I really don’t like FromStr. It feels like "too much magic" to me: when reading code that uses it, I sometimes have no idea what the expected type is because the compiler infers it.

Back then it was typically used with from_str, but nowadays you have the parse method which is a common interface for parsing all kinds of types, and is covered pretty early on in the rust book. Yeah the type is still inferred, but I don't think it's all that confusing when you have something like "thing".parse::<Type>() or let ty: Type = "thing".parse().unwrap(). Another difference from the time that was written is that parse() now yields a Result, so you don't lose error information when the parsing fails.

rust-lang/regex and rust-lang/glob also have impls for this trait, and I've seen it in many other packages as well, such as the toml package. It's a nice, uniform way of parsing strings, especially for types like these that map very readily to existing methods.

[SimonSapin]

I’m still not a huge fan of FromStr, but I suppose it doesn’t hurt much to implement it.

Thanks for the patch!

[SimonSapin]

Published as v0.2.43 on crates.io.

[blaenk]

Sweet thanks!

On Sunday, May 10, 2015, Simon Sapin notifications@github.com wrote:

Published as v0.2.43 on crates.io.

—
Reply to this email directly or view it on GitHub
#107 (comment).

• Jorge Israel Peña