Implemented the origin method (fixes #54)

[KiChjang]

Fixes #54, but still need some clarafication as to how to generate a GUID for schemes such as blob, file and others.

[Manishearth]

Are we sure that the port will always be the default one? With a quick look at the code that seems to be the case.

Otherwise lgtm.

Generating guids probably can be done with https://crates.io/crates/uuid.

[KiChjang]

@Manishearth Where do you see that port always return the default one?

[Manishearth]

As in the port included in a URL that didn't specifically say one.

[KiChjang]

Good catch, there's a method called port_or_default

[SimonSapin]

Generating guids probably can be done with https://crates.io/crates/uuid.

That’s unclear to me. I’ve filed whatwg/url#21 on the spec.

[SimonSapin]

I think that "globally unique identifiers" for the purpose of URL origins are not UUIDs, but are the same as "opaque identifier" as defined in HTML: https://html.spec.whatwg.org/multipage/browsers.html#origin

[Manishearth]

I don't know; Blob URIs use GUIDs I think.

[SimonSapin]

@Manishearth [citation needed] :)

[Manishearth]

https://w3c.github.io/FileAPI/#unicodeSerializationOfBlobURL

[SimonSapin]

http://krijnhoetmer.nl/irc-logs/whatwg/20150522#l-267

[KiChjang]

Hmm... how exactly do we implement opaque identifiers?
On May 22, 2015 6:30 AM, "Simon Sapin" notifications@github.com wrote:

http://krijnhoetmer.nl/irc-logs/whatwg/20150522#l-267

—
Reply to this email directly or view it on GitHub
#111 (comment).

[SimonSapin]

Unclear to me. I’m trying to figure this out:

whatwg/url#21
https://www.w3.org/Bugs/Public/show_bug.cgi?id=28675

[Manishearth]

Internal values, with no serialisation, for which the only meaningful operation is testing for equality.

Would a wrapped 256-bit hash (or something) do?

[SimonSapin]

A hash of what data?

[Manishearth]

Oh, sorry, I got confused there.

We could just hash random values but we're back to GUIDs.

Really, we can just use uuid or similar to create a number and then wrap the number in an opaque (except for PartialEq/Eq) tuple struct.

[KiChjang]

What exactly is this opaque tuple struct? How does it look like? Does my current implementation suffice?

[Manishearth]

#[derive(Debug, PartialEq, Eq, Copy)] pub struct OpaqueOrigin(u64);

Inner value is private, thus, opaque.

-----Original Message-----
From: "Keith Yeung" notifications@github.com
Sent: ‎5/‎23/‎2015 2:08 AM
To: "servo/rust-url" rust-url@noreply.github.com
Cc: "Manish Goregaokar" manishsmail@gmail.com
Subject: Re: [rust-url] Implemented the origin method (fixes #54) (#111)

What exactly is this opaque tuple struct? How does it look like? Does my current implementation suffice?
—
Reply to this email directly or view it on GitHub.

[KiChjang]

r? @SimonSapin

[SimonSapin]

This still seems very wrong to me, but apparently generating a new random identifier every time the method is called is indeed intentional: whatwg/url#56

@bors-servo r+

[bors-servo]

📌 Commit 08ea09c has been approved by SimonSapin

[bors-servo]

⌛ Testing commit 08ea09c with merge a3cd772...

[bors-servo]

☀️ Test successful - travis