Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #124 integer underflow in slicing base URL path components. #125
Conversation
|
@bors-servo r+ Reviewed 2 of 2 files at r1. Comments from the review on Reviewable.io |
|
I guess this one isn't on bors yet. Fixing. |
|
I suspect Cargo will want this on crates.io. @alexcrichton ? |
|
@bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Aug 10, 2015
Fix #124 integer underflow in slicing base URL path components. #124 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/125) <!-- Reviewable:end -->
|
That would indeed be nice :) |
|
|
|
@bors-servo retry Timeout when downloading rust |
bors-servo
pushed a commit
that referenced
this pull request
Aug 11, 2015
Fix #124 integer underflow in slicing base URL path components. #124 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/125) <!-- Reviewable:end -->
|
|
Merged
frewsxcv
added a commit
to frewsxcv/web-platform-tests
that referenced
this pull request
Aug 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedAug 10, 2015
#124