Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdjust set_query_from_pairs bounds #129
Merged
Conversation
|
Looks good. @bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 3, 2015
Adjust set_query_from_pairs bounds The bounds of `Url::set_query_from_pairs` now match the ones from `form_urlencoded::serialize`. The previous bounds did not allow e.g. passing in slices or iterators thereof. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/129) <!-- Reviewable:end -->
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
panicbit commentedSep 3, 2015
The bounds of
Url::set_query_from_pairsnow match the ones fromform_urlencoded::serialize.The previous bounds did not allow e.g. passing in slices or iterators thereof.