Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd crate type #13
Closed
add crate type #13
+1
−0
Conversation
|
Why? |
|
To build it without cargo. |
|
Why? |
|
Also, you can always run |
|
It's --crate-type=lib. |
|
Yeah, that. |
|
You might as well remove crate_name if cargo is a hard dependency for rust-url. |
|
Good point. I had to keep it at some point because of a Cargo bug, but that’s fixed now. 637a57a. Cargo is not a hard dependency, you just need whatever other build system you use to pass the right flags to rustc, as Cargo does. (Namely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mahkoh commentedAug 24, 2014
No description provided.