Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds docs for form_urlencoded::parse #130
Merged
+3
−0
Conversation
|
That’s a good point, thanks! @bors-servo r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 16, 2015
Adds docs for form_urlencoded::parse Hello, I found myself wondering if this function would actually decode the values, as opposed to just splitting on the `=` sign and making some validity checks. I would be nice to have docs just say that the names/values are decoded. Best regards, Conrad <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/130) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
conradkleinespel commentedSep 16, 2015
Hello,
I found myself wondering if this function would actually decode the values, as opposed to just splitting on the
=sign and making some validity checks. I would be nice to have docs just say that the names/values are decoded.Best regards,
Conrad