Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdded VALUE_CHARS EncodeSet #134
Merged
+40
−0
Conversation
This character set is based off of rfc5987 section 3.2 https://tools.ietf.org/html/rfc5987#section-3.2 for the ABNF `value-chars` which is used by certain HTTP header field values such as Content-Disposition `filename*`
|
This is HTTP-specific, right? How about To use it from other crates you’ll also want to add an |
|
Ok, I think I've addressed your concerns in this last commit. |
|
Looks good. @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 13, 2015
Added VALUE_CHARS EncodeSet This character set is based off of rfc5987 section 3.2 https://tools.ietf.org/html/rfc5987#section-3.2 for the ABNF `value-chars` which is used by certain HTTP header field values such as Content-Disposition `filename*` Not sure about the constant name 'VALUE_CHARS' <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/134) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mikedilger commentedNov 12, 2015
This character set is based off of rfc5987 section 3.2
https://tools.ietf.org/html/rfc5987#section-3.2
for the ABNF
value-charswhich is used by certain HTTPheader field values such as Content-Disposition
filename*Not sure about the constant name 'VALUE_CHARS'