Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMove all tests to tests/ folder. #139
Conversation
The folder is provided by Cargo and makes it easier to find tests.
|
I’m not exactly opposed to this change, but I don’t understand: what’s the point? Are they really hard to find where they are now? http://doc.crates.io/guide.html#tests describes the two places to have tests as "should be unit tests" and "should be integration tests" but the difference is not really clear to me.
|
|
My point is just that all other crates I know use the tests/ directory to for integration tests and I consider the tests using test files as integration tests. |
|
Chatting on IRC, other people seem to agree with this change. @bors-servo r+ |
|
|
Move all tests to tests/ folder. The folder is provided by Cargo and makes it easier to find tests. Question: I found that src/parser.rs contains many parsers, should I move `parse_ipv4addr` and `parse_ipv6addr` to the parsers file? <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/139) <!-- Reviewable:end -->
|
|
pyfisch commentedNov 20, 2015
The folder is provided by Cargo and makes it easier to find tests.
Question: I found that src/parser.rs contains many parsers, should I move
parse_ipv4addrandparse_ipv6addrto the parsers file?