Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upimprove `Origin` #147
Merged
improve `Origin` #147
Conversation
|
Looks good, thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 24, 2015
improve `Origin` Add a `::new()` constructor to `OpaqueOrigin` to be able to construct origins from external code too. Derive `HeapSizeOf` for `Origin`. fixes #144 fixes #145 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/147) <!-- Reviewable:end -->
|
|
|
Sorry I forgot to commit the heap size for OpaqueOrigin. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 24, 2015
improve `Origin` Add a `::new()` constructor to `OpaqueOrigin` to be able to construct origins from external code too. Derive `HeapSizeOf` for `Origin`. fixes #144 fixes #145 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/147) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pyfisch commentedNov 24, 2015
Add a
::new()constructor toOpaqueOriginto be able to construct originsfrom external code too. Derive
HeapSizeOfforOrigin.fixes #144
fixes #145