Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIDNA support #152
Merged
IDNA support #152
+21,851
−12
Conversation
Merged
| if { | ||
| let mut chars = label.chars(); | ||
| let _first = chars.next(); | ||
| let _first = chars.next(); |
This comment has been minimized.
This comment has been minimized.
| // Input is from nfc(), so it must be in NFC? | ||
| // Can not contain '.' since the input is from .split('.') | ||
| if { | ||
| let mut chars = label.chars(); |
This comment has been minimized.
This comment has been minimized.
pyfisch
Jan 16, 2016
Contributor
You can use let mut chars = label.chars().skip(2);
http://doc.rust-lang.org/std/iter/trait.Iterator.html#method.skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedDec 5, 2015
@valenting, I rebased your PR #119 and then worked on it some. Could you have a look?
Two things are known missing (and have FIXME comments):
There are some tests that are supposed to return an error but currently don’t. (The corresponding
assert!is commented out.) Some are because of the bidi rule, but I’m not sure about others. (For examplea\u200Cb.)