Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Url::join #153

Merged
merged 1 commit into from Dec 11, 2015
Merged

Introduce Url::join #153

merged 1 commit into from Dec 11, 2015

Conversation

@nox
Copy link
Member

nox commented Dec 10, 2015

Review on Reviewable
@nox nox added the enhancement label Dec 10, 2015
@SimonSapin
Copy link
Member

SimonSapin commented Dec 10, 2015

r=me with a version number bump
@nox nox force-pushed the nox:join branch 2 times, most recently from 095ef74 to 7c09184 Dec 11, 2015
@nox
Copy link
Member Author

nox commented Dec 11, 2015

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

📌 Commit 7c09184 has been approved by SimonSapin
@SimonSapin
Copy link
Member

SimonSapin commented Dec 11, 2015

@bors-servo r-
@SimonSapin
Copy link
Member

SimonSapin commented Dec 11, 2015

Sorry, I should have been more precise. This should be 0.5.2, not 0.6.0 since it’s a backward compatible addition. (And updating all the things for semver-incompatible versions is a pain.)
@nox
Copy link
Member Author

nox commented Dec 11, 2015

@SimonSapin Sorry myself, I know the rules, just forgot that semver with 0.y.z is different than with 1.y.z.
@nox
Introduce Url::join
Loading status checks…
0ad4d96
@nox nox force-pushed the nox:join branch from 7c09184 to 0ad4d96 Dec 11, 2015
@SimonSapin
Copy link
Member

SimonSapin commented Dec 11, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

📌 Commit 0ad4d96 has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

⌛ Testing commit 0ad4d96 with merge 2aa249b...
bors-servo added a commit that referenced this pull request Dec 11, 2015
@bors-servo
Auto merge of #153 - nox:join, r=SimonSapin
Loading status checks…
2aa249b 
Introduce Url::join

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/153)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Dec 11, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit 0ad4d96 into servo:master Dec 11, 2015
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin mentioned this pull request Mar 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @SimonSapin @bors-servo
You can’t perform that action at this time.