Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix building with current rust #16
Merged
Conversation
&[T, ..n] isn't coerced to &[T] anymore, so we have to manually do that in a few places.
| None => if isindex { (&[], piece) } else { (piece, &[]) } | ||
| None => { | ||
| let tmp: (&[u8], &[u8]) = if isindex { (&[], piece) } else { (piece, &[]) }; | ||
| tmp |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dotdash
Aug 26, 2014
Author
Contributor
No, the special rules for let foo = &rvalue expand the lifetime of the vector here. Those rules don't apply for [].as_slice() so you get a lifetime error.
This comment has been minimized.
This comment has been minimized.
SimonSapin
added a commit
that referenced
this pull request
Aug 26, 2014
Fix building with current rust
|
Merged, thanks! |
|
D'oh, actually I'm an idiot. I'm at a different box now and didn't upgrade rustc yet. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dotdash commentedAug 26, 2014
&[T, ..n] isn't coerced to &[T] anymore, so we have to manually do that
in a few places.