Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChange return type of password_mut to Option<&mut Option<String>> #169
Conversation
|
r? @SimonSapin |
|
This is sensible, but I have an in-progress rewrite that makes it obsolete: https://github.com/servo/rust-url/compare/1.0 (The password and other components will not be independent So making a breaking release if another one is coming soon may not be worth it. In the mean time, as discussed on IRC, you can use the |
|
Ah ok, the rewrite makes more sense then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
KiChjang commentedFeb 13, 2016
This is necessary because by default, if the URL ':' delimiter was not found in the URL, then password_mut() would return None, causing a later mutation to the password field in RelativeSchemeData impossible.