Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd idna::domain_to_unicode #172
Merged
+60
−43
Conversation
|
Reviewed 4 of 4 files at r1. Comments from the review on Reviewable.io |
|
@bors-servo r=valenting |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 26, 2016
Add idna::domain_to_unicode This is used by the "Unicode serialisation of an origin", which is used by the getter of the `URL::origin` WebIDL attribute. r? @valenting <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/172) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedFeb 26, 2016
This is used by the "Unicode serialisation of an origin", which is used by the getter of the
URL::originWebIDL attribute.r? @valenting