Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New IntoUrl trait #177

Closed
wants to merge 40 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
918352b
Make it possible to define new encode sets in other crates.
SimonSapin Dec 4, 2015
db9de70
Define encode sets based on another set.
SimonSapin Dec 4, 2015
691aec2
Remove the HTTP_VALUE encode set. It can be defined in another crate.
SimonSapin Dec 4, 2015
d140dc8
Rewrite ALL THE THINGS!
SimonSapin Dec 9, 2015
9edff44
Remove the dependency on uuid.
SimonSapin Feb 8, 2016
576bd2a
Add URL slicing/indexing by component.
SimonSapin Feb 8, 2016
7b11445
Add stubs with partial implementation for the WebIDL API.
SimonSapin Feb 8, 2016
c617ed1
Shorter Cargo.toml syntax.
SimonSapin Feb 8, 2016
22cf104
serde_serialization -> serde
SimonSapin Feb 8, 2016
0cb3f2b
Make rustc-serialize an optional dependency.
SimonSapin Feb 8, 2016
61a8185
Rename *{Start,End} posititons to {Before,After}*
SimonSapin Feb 9, 2016
813d270
Replace from_hex() with char::to_digit(16)
SimonSapin Feb 9, 2016
0b5ffb4
Make percent-decoding an iterator.
SimonSapin Feb 9, 2016
244d999
Make percent-encoding an iterator.
SimonSapin Feb 9, 2016
7b33b33
Add percent-encoding convienience wrappers.
SimonSapin Feb 9, 2016
ca9f87d
Update tests from https://github.com/w3c/web-platform-tests/blob/mast…
SimonSapin Feb 10, 2016
7a0e467
Remove Url::has_host
SimonSapin Feb 11, 2016
9a8d394
Remove unused ParseError variants
SimonSapin Feb 12, 2016
903f1d2
Make context a field of Parser.
SimonSapin Feb 11, 2016
a9b4e71
Remove the redundant is_relative field.
SimonSapin Feb 15, 2016
ded48a2
Add Url::domain and Url::ip_address
SimonSapin Feb 15, 2016
d3dba86
Implement ToSocketAddrs
SimonSapin Feb 15, 2016
088c3ed
Remove Url::ip_address for now
SimonSapin Feb 15, 2016
641f940
Add Unicode and ASCII serializations of origins
SimonSapin Feb 16, 2016
946d950
Test WebIdl::origin
SimonSapin Feb 16, 2016
4dff876
Add a fragment setter
SimonSapin Feb 11, 2016
0ae07ed
Add a query setter.
SimonSapin Feb 12, 2016
542feb0
Make Url::parse_with usable. (EncodingOverride is private.)
SimonSapin Feb 19, 2016
dd0436a
Add Origin::is_tuple
SimonSapin Feb 19, 2016
f7e0d7c
More consistent checks for URL with authority or path-only.
SimonSapin Feb 19, 2016
fd16b74
Re-export OpaqueOrigin. It is exposed publicly through Origin::Opaque
SimonSapin Feb 19, 2016
f1bdaa6
Add a scheme setter
SimonSapin Feb 19, 2016
158145f
Add host setters.
SimonSapin Feb 19, 2016
b1b0916
More setters
SimonSapin Feb 23, 2016
47e31ef
Add a path setter
SimonSapin Feb 26, 2016
e7a4dc0
Username and passowrd setters
SimonSapin Feb 26, 2016
5b26c89
More WebIDL implementations.
SimonSapin Feb 26, 2016
bf0f670
Port setters
SimonSapin Mar 1, 2016
b89d7d7
All setters.
SimonSapin Mar 1, 2016
3f9dcd4
New IntoUrl trait
cmbrandenburg Mar 4, 2016
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Add a scheme setter

  • Loading branch information
SimonSapin committed Mar 3, 2016
commit f1bdaa623156adcca31748187d5ac2420b5ecbce
@@ -423,13 +423,7 @@ impl Url {
}

fn mutate<F: FnOnce(&mut Parser) -> R, R>(&mut self, f: F) -> R {
let mut parser = Parser {
serialization: mem::replace(&mut self.serialization, String::new()),
base_url: None,
query_encoding_override: EncodingOverride::utf8(),
log_syntax_violation: None,
context: Context::Setter,
};
let mut parser = Parser::for_setter(mem::replace(&mut self.serialization, String::new()));
let result = f(&mut parser);
self.serialization = parser.serialization;
result
@@ -480,6 +474,43 @@ impl Url {
}
}

/// Change this URL’s scheme.
///
/// Do nothing and return `Err` if:
/// * The new scheme is not in `[a-zA-Z][a-zA-Z0-9+.-]+`
/// * This URL is non-relative and the new scheme is one of
/// `http`, `https`, `ws`, `wss`, `ftp`, or `gopher`
pub fn set_scheme(&mut self, scheme: &str) -> Result<(), ()> {
self.set_scheme_internal(scheme, false)
}

fn set_scheme_internal(&mut self, scheme: &str, allow_extra_input_after_colon: bool)
-> Result<(), ()> {
let mut parser = Parser::for_setter(String::new());
let remaining = try!(parser.parse_scheme(scheme));
if !(remaining.is_empty() || allow_extra_input_after_colon) {
return Err(())
}
let old_scheme_end = self.scheme_end;
let new_scheme_end = to_u32(parser.serialization.len()).unwrap();
let adjust = |index: &mut u32| {
*index -= old_scheme_end;
*index += new_scheme_end;
};

self.scheme_end = new_scheme_end;
adjust(&mut self.username_end);
adjust(&mut self.host_start);
adjust(&mut self.host_end);
adjust(&mut self.path_start);
if let Some(ref mut index) = self.query_start { adjust(index) }
if let Some(ref mut index) = self.fragment_start { adjust(index) }

parser.serialization.push_str(self.slice(old_scheme_end..));
self.serialization = parser.serialization;
Ok(())
}

/// Convert a file name as `std::path::Path` into an URL in the `file` scheme.
///
/// This returns `Err` if the given path is not absolute or,
@@ -109,6 +109,16 @@ pub enum Context {
}

impl<'a> Parser<'a> {
pub fn for_setter(serialization: String) -> Parser<'a> {
Parser {
serialization: serialization,
base_url: None,
query_encoding_override: EncodingOverride::utf8(),
log_syntax_violation: None,
context: Context::Setter,
}
}

fn syntax_violation(&self, reason: &'static str) {
if let Some(log) = self.log_syntax_violation {
log(reason)
@@ -43,9 +43,9 @@ impl WebIdl {
url.slice(..url.scheme_end + 1)
}

/// **Not implemented yet** Setter for https://url.spec.whatwg.org/#dom-url-protocol
pub fn set_protocol(_url: &mut Url, _new_protocol: &str) {
unimplemented!() // FIXME
/// Setter for https://url.spec.whatwg.org/#dom-url-protocol
pub fn set_protocol(url: &mut Url, new_protocol: &str) {
let _ = url.set_scheme_internal(new_protocol, true);
}

/// Getter for https://url.spec.whatwg.org/#dom-url-username
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.