Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split IDNA into a separate crate #181

Closed
wants to merge 2 commits into from
Closed

Split IDNA into a separate crate #181

wants to merge 2 commits into from

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Mar 30, 2016

murarth/resolve#4

r? @nox

This change is Reviewable
SimonSapin added 2 commits Mar 30, 2016
@SimonSapin
Split IDNA into a separate crate.
aba50d2
@SimonSapin
IDNA: One test in the test harness per test case.
Loading status checks…
ae90bc3 
This makes individual failures show up separately.
@nox
Copy link
Member

nox commented Mar 30, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

📌 Commit ae90bc3 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

⌛ Testing commit ae90bc3 with merge f62547a...
bors-servo added a commit that referenced this pull request Mar 30, 2016
@bors-servo
Auto merge of #181 - servo:idna-crate, r=nox
Loading status checks…
f62547a 
Split IDNA into a separate crate

murarth/resolve#4

r? @nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/181)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 30, 2016

💔 Test failed - travis
@SimonSapin
Copy link
Member Author

SimonSapin commented Mar 30, 2016

Forgot to update the url crate to use the new idna crate. Making uts46::Error private is technically a breaking change (even though probably nobody used it) but I don’t really want to release another breaking version before #176 so I’ll lump this into #176.
@SimonSapin SimonSapin closed this Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@SimonSapin @nox @bors-servo
You can’t perform that action at this time.