Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a corner case and add some tests #187

Merged
merged 3 commits into from Apr 21, 2016
Merged

Fix a corner case and add some tests #187

merged 3 commits into from Apr 21, 2016

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Apr 21, 2016

This change is Reviewable
SimonSapin added 2 commits Apr 21, 2016
@SimonSapin
Fix a corner case of Url::set_host
bb72f19 
Some URLs can be like foo:///bar with an authority but no host.
This is different from foo:/bar with no authority.

Fix #25
@SimonSapin
Add a test default port number when changing scheme.
Loading status checks…
1c2f149 
Closes #61. (It was fixed by #176.)
@SimonSapin SimonSapin mentioned this pull request Apr 21, 2016
Closed
@nox
Copy link
Member

nox commented Apr 21, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

📌 Commit 1c2f149 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

⌛ Testing commit 1c2f149 with merge b93cfef...
bors-servo added a commit that referenced this pull request Apr 21, 2016
@bors-servo
Auto merge of #187 - servo:stuff, r=nox
Loading status checks…
b93cfef 
Fix a corner case and add some tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/187)
<!-- Reviewable:end -->
@nox nox self-assigned this Apr 21, 2016
@SimonSapin
Hide Url::assert_invariants from docs.
Loading status checks…
0c12771
@nox
Copy link
Member

nox commented Apr 21, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

📌 Commit 0c12771 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

⌛ Testing commit 0c12771 with merge e96d5a4...
bors-servo added a commit that referenced this pull request Apr 21, 2016
@bors-servo
Auto merge of #187 - servo:stuff, r=nox
Loading status checks…
e96d5a4 
Fix a corner case and add some tests

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/187)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit 0c12771 into master Apr 21, 2016
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the stuff branch Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@SimonSapin @nox @bors-servo
You can’t perform that action at this time.