Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer mutate path segments #189

Merged
merged 2 commits into from Apr 21, 2016
Merged

Defer mutate path segments #189

merged 2 commits into from Apr 21, 2016
+10 −8

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Apr 21, 2016

This change is Reviewable
SimonSapin added 2 commits Apr 21, 2016
@SimonSapin
Rename mutate_query_pairs to query_pairs_mut.
b6fbbca 
This is more in line with standard library convensions,
and we’ll add path_segments_mut later.
@SimonSapin
Make pop_path_segment and push_path_segment private for now.
Loading status checks…
e185a86 
See #188
@nox
Copy link
Member

nox commented Apr 21, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

📌 Commit e185a86 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

⌛ Testing commit e185a86 with merge d5a84c9...
bors-servo added a commit that referenced this pull request Apr 21, 2016
@bors-servo
Auto merge of #189 - servo:defer-mutate-path-segments, r=nox
Loading status checks…
d5a84c9 
Defer mutate path segments

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/189)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Apr 21, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit e185a86 into master Apr 21, 2016
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the defer-mutate-path-segments branch Apr 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@SimonSapin @nox @bors-servo
You can’t perform that action at this time.