Add Url::path_segments_mut, fix #188

[SimonSapin]

@sfackler @maximih @jgillich How does this look? Would these new API help for your use cases? Can they be improved?

@nox, please review but don’t land yet.

---

This change is

[sfackler]

This looks great!

[mhristache]

I think it looks good even though I find this a bit unexpected:

extern crate url;

fn main() {

    let mut my_url = url::Url::parse("http://this/is/a").unwrap();

    let new_url = my_url.join("./test").unwrap();
    println!("{}", new_url.as_str());

    my_url.path_segments_mut().unwrap().push("./test");
    println!("{}", my_url.as_str());
}

Which prints:

http://this/is/test
http://this/is/a/.%2Ftest

where I was expecting http://this/is/a/test so that it's consistent with join() implementation.

Anyhow, it's not a big deal as I can fi it by using my_url.path_segments_mut().unwrap().push("test")

So I am happy with the implementation. Thanks for your effort

[SimonSapin]

It is by design that PathSegmentsMut::push escapes slashes and does not interpret . or .. specially: it adds exactly one segment, whatever the characters in that segment. The point is not to do the same as join, you can use join for that.

Actually, I wonder what push(".") or push("..") should do. With the code is it currently is, Url::parse(url.as_str()).unwrap() == url would not hold, since . and .. segments are normalized during parsing. @nox, what do you think?

[nox]

@nox, what do you think?

That's a good question. Maybe it should panic on . and ..?

Btw, r=me for the rest.

[SimonSapin]

I've added a commit to ignore . and make .. behave like pop()

[SimonSapin]

@bors-servo r=nox

(IRC)

[bors-servo]

📌 Commit e66486a has been approved by nox

[bors-servo]

⌛ Testing commit e66486a with merge d91d175...

[bors-servo]

☀️ Test successful - travis