Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Url::from_file_path not generate an URL with an empty path. Fix #197 #198

Merged
merged 1 commit into from May 25, 2016
Merged

Have Url::from_file_path not generate an URL with an empty path. Fix #197 #198

merged 1 commit into from May 25, 2016

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented May 25, 2016 •
edited by larsbergstrom

This change is Reviewable
@SimonSapin
Have Url::from_file_path not generate an URL with an empty path. Fix #…
Loading status checks…
ce6ca74 
…197.
@SimonSapin SimonSapin mentioned this pull request May 25, 2016
Closed
@mbrubeck
Copy link
Contributor

mbrubeck commented May 25, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2016

📌 Commit ce6ca74 has been approved by mbrubeck
@mbrubeck mbrubeck self-assigned this May 25, 2016
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2016

⌛ Testing commit ce6ca74 with merge f36d48d...
bors-servo added a commit that referenced this pull request May 25, 2016
@bors-servo
Auto merge of #198 - servo:empty-path, r=mbrubeck
Loading status checks…
f36d48d 
Have Url::from_file_path not generate an URL with an empty path. Fix #197

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/198)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit ce6ca74 into master May 25, 2016
2 of 5 checks passed
2 of 5 checks passed
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
homu Testing commit ce6ca74 with merge f36d48d...
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@SimonSapin SimonSapin deleted the empty-path branch Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@SimonSapin @mbrubeck @bors-servo
You can’t perform that action at this time.