Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDocument common changes needed during a 0.x -> 1.x upgrade #205
Conversation
|
r? @SimonSapin |
|
Closing in favor of #206! |
|
Since I used your commit as-is let’s let github mark it as merged :) |
bors-servo
added a commit
that referenced
this pull request
Jun 27, 2016
Add some to UPGRADING.md This is a few additions on top of #205. Thanks @carols10cents starting this! <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/206) <!-- Reviewable:end -->
|
Ok! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
carols10cents commentedJun 25, 2016
•
edited by larsbergstrom
Hi! I had to upgrade another crate from 0.x to 1.x, so I decided to actually write up what I did. Then I went and looked at the crates that @SimonSapin upgraded and found some more. I also spot checked a few reverse dependency crates that have done this upgrade. So I'm sure there are more changes that I'm missing, but these should be the most common ones.
There are still quite a few crates that are using url 0.x listed on crates.io, I hope this will help when they decide to upgrade!🎉
This change is