Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax url parsing to support youtube URLs which don't strictly follow… #208

Closed
wants to merge 1 commit into from
Closed

Relax url parsing to support youtube URLs which don't strictly follow… #208

wants to merge 1 commit into from

Conversation

@jezell
Copy link
Contributor

jezell commented Jul 1, 2016 •
edited by larsbergstrom

Fixes #207

This change is Reviewable
@Manishearth
Copy link
Member

Manishearth commented Jul 1, 2016

Thanks for your contribution! This looks good to me; but I'll wait for @SimonSapin to review it 😄
@jezell
Relax url parsing to support youtube URLs which don't strictly follow…
Loading status checks…
0a23b31 
… the rules
@jezell jezell force-pushed the jezell:relax_validation branch from 9ded233 to 0a23b31 Jul 1, 2016
@Ms2ger Ms2ger mentioned this pull request Jul 1, 2016
Closed
@metajack
Copy link
Contributor

metajack commented Jul 11, 2016

reping @SimonSapin
@emilio emilio mentioned this pull request Nov 19, 2016
Merged
@SimonSapin
Copy link
Member

SimonSapin commented Nov 22, 2016

Ugh, sorry I let this slip through. In the end we removed that check entirely, without a configuration option: #240.

Thanks for the patch anyway!
@SimonSapin SimonSapin closed this Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SimonSapin SimonSapin

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jezell @Manishearth @metajack @SimonSapin
You can’t perform that action at this time.