Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replace bad grammar #217

Closed
wants to merge 1 commit into from
+1 −1
Closed

doc: replace bad grammar #217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

2 src/lib.rs
View file
Open in desktop
@@ -368,7 +368,7 @@ impl Url {

/// Return the origin of this URL (https://url.spec.whatwg.org/#origin)
///
/// Note: this return an opaque origin for `file:` URLs, which causes
/// Note: the return value is an opaque origin for `file:` URLs, which causes

This comment has been minimized.

Sign in to view
@KiChjang

KiChjang Aug 4, 2016

Member

Equivalently, "this returns" would fix all of the problems here. Your new wording makes the "which causes..." part sound very strange since it isn't clear on what the "which" is referring to.
/// `url.origin() != url.origin()`.
///
/// # Examples
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.