Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate the serialization in Url::take_after_path #223

Merged
merged 4 commits into from Sep 28, 2016
Merged

Truncate the serialization in Url::take_after_path #223

merged 4 commits into from Sep 28, 2016
+50 −11

Commits on Sep 18, 2016

  1. Truncate the serialization in Url::take_after_path, discard empty seg… 

    …ments in PathSegmentsMut::extend.

Fixes #222
    @emilio
    emilio committed Sep 18, 2016
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    5a77f26

  2. Now the old after path position is always the serialization.

    @emilio
    emilio committed Sep 18, 2016
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    7225866

  3. test: Add test for #227

    @emilio
    emilio committed Sep 18, 2016
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    4c2b7f8

  4. test: don't compile test for #197 on windows. 

    Windows expects in `path_to_file_url_segments_windows` a Disk or a VerbatimDisk
as the first path component, which this test doesn't hold, and thus it panic.

I sincerely don't know how this could pass in the first time (did it?).
    @emilio
    emilio committed Sep 18, 2016
    Loading status checks…
    Unverified
    This user has not uploaded their public key yet.
    GPG key ID: 056B727BB9C1027C Learn about signing commits
    4d4f1a3
You can’t perform that action at this time.