Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few doc examples. #228

Merged
merged 3 commits into from Nov 1, 2016
Merged

Add a few doc examples. #228

merged 3 commits into from Nov 1, 2016
+39 −0

Conversation

@frewsxcv
Copy link
Member

frewsxcv commented Sep 30, 2016 •
edited by larsbergstrom

This change is Reviewable
@frewsxcv
Add doc example for url::Url::port.
f032633
@frewsxcv frewsxcv force-pushed the doc-examples branch from 326b3f7 to 2b4a92a Sep 30, 2016
@frewsxcv
Copy link
Member Author

frewsxcv commented Sep 30, 2016

r? @SimonSapin
frewsxcv added 2 commits Sep 30, 2016
@frewsxcv
Add doc example for url::Url::port_or_known_default.
4c8aca6
@frewsxcv
Add doc example for url::Url::domain.
Loading status checks…
10ececb
@frewsxcv frewsxcv force-pushed the doc-examples branch from 2b4a92a to 10ececb Sep 30, 2016
@untitaker
Copy link
Contributor

untitaker commented Sep 30, 2016

Spurious CI failure.
@Hoverbear
Copy link
Member

Hoverbear commented Sep 30, 2016

Restarting build.
@Hoverbear
Copy link
Member

Hoverbear commented Oct 1, 2016

Tests pass! =D
@Hoverbear
Hoverbear approved these changes Oct 1, 2016
View changes
@SimonSapin
Copy link
Member

SimonSapin commented Nov 1, 2016

Sorry I forgot about this.

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2016

📌 Commit 10ececb has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2016

⌛ Testing commit 10ececb with merge 23601ba...
bors-servo added a commit that referenced this pull request Nov 1, 2016
@bors-servo
Auto merge of #228 - servo:doc-examples, r=SimonSapin
Loading status checks…
23601ba 
Add a few doc examples.

<!-- Reviewable:start -->

This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/228)

<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Nov 1, 2016

☀️ Test successful - status-travis
@bors-servo bors-servo merged commit 10ececb into master Nov 1, 2016
6 checks passed
6 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the doc-examples branch Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hoverbear Hoverbear

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@frewsxcv @untitaker @Hoverbear @SimonSapin @bors-servo
You can’t perform that action at this time.