Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTeach to_file_path to understand percent-encoded drive letters on Windows. #231
+29
−5
Conversation
|
Converting to/from file paths is not covered by https://url.spec.whatwg.org/ , so it’s probably fine to tweak that behavior. Looks good, thanks! @bors-servo r+ |
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 20, 2016
Teach to_file_path to understand percent-encoded drive letters on Windows. Fixes #230 --- I thought about using `percent_encoded` instead of matching `%3a` bytes individually, but I figured it would be overkill. If you think otherwise I'm happy to change it. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/231) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Arnavion commentedOct 20, 2016
•
edited by larsbergstrom
Fixes #230
I thought about using
percent_encodedinstead of matching%3abytes individually, but I figured it would be overkill. If you think otherwise I'm happy to change it.This change is