Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix support for for IPv4-in-IPv6 syntax. #237
Merged
Conversation
|
Not sure if I've understood the code properly, might need to look at the context more. r=me though, will go through in depth later. Could you also bump the version? |
|
ah, I understand now. r=me with or without the version bump |
|
Also importing new tests from WPT, which I assume have been reviewed upstream. @bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 30, 2016
Fix support for for IPv4-in-IPv6 syntax. r? @Manishearth <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/237) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
SimonSapin commentedOct 30, 2016
•
edited
r? @Manishearth
This change is