Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a few doc examples. #239
Merged
+54
−0
Conversation
| /// | ||
| /// let url = Url::parse("https://example.net").unwrap(); | ||
| /// let url = url.join("foo").unwrap(); | ||
| /// assert_eq!(url.as_str(), "https://example.net/foo"); |
This comment has been minimized.
This comment has been minimized.
SimonSapin
Nov 14, 2016
Member
Please change this to showcase trailing slashes: https://example.net/foo joined with bar is https://example.net/bar, but https://example.net/foo/ joined with bar is https://example.net/foo/bar
r=me with this.
|
@bors-servo r=SimonSapin |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 14, 2016
Add a few doc examples. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/239) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
frewsxcv commentedNov 10, 2016
•
edited by larsbergstrom
This change is