Skip to content

/ rust-url

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.2.4 #251

Merged
merged 1 commit into from Dec 17, 2016
Merged

Bump to 1.2.4 #251

merged 1 commit into from Dec 17, 2016
+1 −1

Conversation

@Manishearth
Copy link
Member

Manishearth commented Dec 17, 2016 •
edited by larsbergstrom

This change is Reviewable
@Manishearth
Copy link
Member Author

Manishearth commented Dec 17, 2016

r=SimonSapin

(waiting on other PR to land)
@Manishearth
Bump to 1.2.4
Loading status checks…
7ae111a
@Manishearth
Copy link
Member Author

Manishearth commented Dec 17, 2016

@bors-servo r=SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2016

📌 Commit 7ae111a has been approved by SimonSapin
@bors-servo
Copy link
Contributor

bors-servo commented Dec 17, 2016

⚡ Test exempted - status
@bors-servo bors-servo merged commit 7ae111a into master Dec 17, 2016
3 of 5 checks passed
3 of 5 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
dependency-ci Dependencies checked
Details
bors-servo added a commit that referenced this pull request Dec 17, 2016
@bors-servo
Auto merge of #251 - servo:bump, r=SimonSapin
Loading status checks…
a00fc90 
Bump to 1.2.4

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/251)
<!-- Reviewable:end -->
@Manishearth Manishearth deleted the bump branch Dec 17, 2016
@sanmai-NL

This comment has been minimized.

Sign in to view
Copy link

sanmai-NL commented on 7ae111a Dec 20, 2016

@Manishearth:
This change isn't reflected as a Git tag on GitHub, nor could I find a changelog/announcement on this release. Bit confusing, esp. given the version number (SemVer?).

This comment has been minimized.

Sign in to view
Copy link
Member

SimonSapin replied Dec 20, 2016

@sanmai-NL git tags are made manually, and we forgot in this case. We haven’t really ever maintained a changelog or done announcement for this library (except for the 0.x to 1.0 rewrite).

Bit confusing, esp. given the version number (SemVer?).

I don’t understand, what does SemVer have to do with git tags or changelogs?

This comment has been minimized.

Sign in to view
Copy link

sanmai-NL replied Dec 20, 2016 •
edited

Hi, I was just explaining where I have been looking for more information on this release.
After SemVer 1.y.z I would expect that releases are cut according to some standard process. In other words, before that, missing Git tags or release notes/changelogs are bit more in line with what I would expect. Not claiming SemVer prescribes this, just stating my assumption you're following SemVer here + my expectations on releases.

Reason for commenting is, I'm using this library quite a lot and perhaps others outside Mozilla are as well. By the way, I'll come back the the open issue I filed some time ago soon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@Manishearth @bors-servo @sanmai-NL @SimonSapin
You can’t perform that action at this time.